dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.
https://docs.microsoft.com/visualstudio/msbuild/msbuild
MIT License
5.21k stars 1.35k forks source link

UWP application new Debug configuration reports TargetedSDKConfiguration = Retail #4021

Open edetoc opened 5 years ago

edetoc commented 5 years ago

Steps to reproduce

1.) Use Visual Studio 2017 version 15.9.4 (or above) 2.) Create a new Visual C# -> Windows Universal -> Blank App (Universal Windows) 3.) In Visual Studio's menu select "Build" -> "Configuration Manager..." 4.) In the "Configuration Manager" dialog in the "Configuration" column click the open arrow and select >New...> to create a new configuration 5.) In the "New Project Configuration" dialog enter a name and in the "Copy settings from:" combo box select "Debug" and press "OK" 6.) In Visual Studio's menu select "Tools" -> "Options..." 7.) In the "Options" dialog choose "Projects and Solutions" -> "Build and Run" 8.) In the "MSBuild project build output verbosity:" combo box select "Diagnostic" 9.) Build the newly created configuration 10.) Check the output from the build

Expected behavior

TargetedSDKConfiguration = Debug

Actual behavior

TargetedSDKConfiguration = Retail

Same problem with C++ UWP.

To workaround the problem you can edit the project file and set explicit `

<TargetedSDKConfiguration>Debug</TargetedSDKConfiguration>

for the new configuration's PropertyGroups.

Environment data

Microsoft Visual Studio Enterprise 2017 Version 15.9.4 VisualStudio.15.Release/15.9.4+28307.222 Microsoft .NET Framework Version 4.7.03190

Installed Version: Enterprise

Visual C++ 2017 00369-60000-00001-AA012 Microsoft Visual C++ 2017

Application Insights Tools for Visual Studio Package 8.14.11009.1 Application Insights Tools for Visual Studio

ASP.NET and Web Tools 2017 15.9.04012.0 ASP.NET and Web Tools 2017

ASP.NET Core Razor Language Services 15.8.31590 Provides languages services for ASP.NET Core Razor.

C# Tools 2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Extensibility Message Bus 1.1.49 (remotes/origin/d15-8@ee674f3) Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

JavaScript Language Service 2.0 JavaScript Language Service

JavaScript Project System 2.0 JavaScript Project System

JavaScript UWP Project System 2.0 JavaScript UWP Project System

JustDecompilePackage2017 Extension 1.0 JustDecompilePackage2017 Visual Studio Extension Detailed Info

Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards 1.0 Microsoft Visual C++ Wizards

Microsoft Visual Studio VC Package 1.0 Microsoft Visual Studio VC Package

MLGen Package Extension 1.0 MLGen Package Visual Studio Extension Detailed Info

Mono Debugging for Visual Studio 4.13.12-pre (9bc9548) Support for debugging Mono processes with Visual Studio.

NuGet Package Manager 4.6.0 NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.

ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info

ResourcePackage Extension 1.0 ResourcePackage Visual Studio Extension Detailed Info

ResourcePackage Extension 1.0 ResourcePackage Visual Studio Extension Detailed Info

SQL Server Data Tools 15.1.61810.11040 Microsoft SQL Server Data Tools

TypeScript Tools 15.9.20918.2001 TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools 2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools 10.2 for F# 4.5 15.8.0.0. Commit Hash: 6e26c5bacc8c4201e962f5bdde0a177f82f88691. Microsoft Visual F# Tools 10.2 for F# 4.5

Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Tools for Apache Cordova 15.123.7408.1 Visual Studio Tools for Apache Cordova

Visual Studio Tools for CMake 1.0 Visual Studio Tools for CMake

Visual Studio Tools for Universal Windows Apps 15.0.28307.208 The Visual Studio Tools for Universal Windows apps allow you to build a single universal app experience that can reach every device running Windows 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 Software Development Kit.

VisualStudio.Mac 1.0 Mac Extension for Visual Studio

Windows Template Studio 2.5.18319.1 Windows Template Studio quickly builds a UWP app, using a wizard-based UI to turn your needs into a foundation of Windows 10 patterns and best practices.

Xamarin 4.12.3.77 (d15-9@e3f40b477) Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer 4.16.13 (45a16efd4) Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates 1.1.128 (6f5ebb2) Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK 9.1.4.2 (HEAD/8255f42fc) Xamarin.Android Reference Assemblies and MSBuild support.

Xamarin.iOS and Xamarin.Mac SDK 12.2.1.12 (65ec520) Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

OS info: Win10 1809

livarcocc commented 5 years ago

I am not sure MSBuild is actually the culprit here. UWP may have its own targets/props playing a role here.

I suggest you filling a feedback ticket for UWP through VS itself and it will go to the right people through there. Meanwhile, I am going to close this issue. If it turns out this is indeed something wrong in MSBuild, we can re-activate.

srdjanjovcic commented 5 years ago

@livarcocc : Issue is that Microsoft.Common.CurrentVersion.targets makes an assumption that configuration can be just Debug or Retail:

  <PropertyGroup>
    <TargetedSDKConfiguration Condition="'$(TargetedSDKConfiguration)' == '' and '_$(Configuration)' == '_Debug'">Debug</TargetedSDKConfiguration>
    <TargetedSDKConfiguration Condition="'$(TargetedSDKConfiguration)' == '' and '_$(Configuration)' == '_Release'">Retail</TargetedSDKConfiguration>
    <TargetedSDKConfiguration Condition="'$(TargetedSDKConfiguration)' == ''">Retail</TargetedSDKConfiguration>
    <TargetedSDKArchitecture Condition="'$(TargetedSDKArchitecture)' == ''">$(ProcessorArchitecture)</TargetedSDKArchitecture>
    <TargetedSDKArchitecture Condition="'$(TargetedSDKArchitecture)' == ''">Neutral</TargetedSDKArchitecture>
  </PropertyGroup>

Can you reactivate the issue? It seems that I cannot do that.

livarcocc commented 5 years ago

@rainersigwald is this code specific to UWP? if so, makes me sad it lives here.

srdjanjovcic commented 5 years ago

@livarcocc , @rainersigwald … Yes, it appears to be UWP-specific code.

EDIT: It seems that there is no existing UWP-specific targets files...