Make VSCode LiveShare work without errors

dotnet / razor

Compiler and tooling experience for Razor ASP.NET Core apps in Visual Studio, Visual Studio for Mac, and VS Code.

https://asp.net

MIT License

505 stars 196 forks source link

Make VSCode LiveShare work without errors #4359

Open NTaylorMullen opened 6 years ago

NTaylorMullen commented 6 years ago

Razor LiveShare in VS Windows is a thing. We need to figure out what it'll take to get a Razor LiveShare experience in VSCode.

fyi @DamianEdwards

NTaylorMullen commented 4 years ago

Some investigations playing around with VSCode LiveShare:

VSCode Insiders -> VSCode completion doesn't work. Throws workspace null on guest
VSCode -> VSCode Insiders. Throws workspace null on guest but otherwise works
VSOnline -> VSCode Insiders provisional completion doesn't work. Throws workspace null on guest
VSOnline -> VSCode provisional completion doesn't work. Throws workspace null on guest

NTaylorMullen commented 4 years ago

Talked with LiveShare team about the workspace being null on the guest and it is definitely unfortunate but after the initialize request no other LSP requests should be sent to the guest LSP. Therefore, we should do the work to make our workspace resolution logic not explode but more importantly short-circuit the remaining file change detector initializations in response.

NTaylorMullen commented 4 years ago

Talked more with LiveShare folks and for our client side functionality such as auto-completing HTML tags and provisional C# completions they suggested it might be wise for us to restrict what type of Razor files we operate on in the client by using document selectors on the client that only understand the file:// scheme (LiveShare uses the vsls scheme).

NTaylorMullen commented 4 years ago

Looks like in the latest release LiveShare stopped working for all sorts of completions.