Stack overflow on struct type with array of pointers to self

[tomrus88]

Version Used: VS 2017 15.5.7 Steps to Reproduce:

1. Create new C# project
2. Paste following code into one of .cs source files ` unsafe struct X { public X[] Y; } `
3. See VS freeze and crash from stack overflow in Microsoft.CodeAnalysis.CSharp.ni.dll

Expected Behavior: VS should not crash. Actual Behavior: VS freezes and crashes.

[jcouv]

Confirmed to repro in 15.6 preview 1.1. I captured a stack trace from the crash and the repeating portion of the stack (copied below) matches an issue that I coincidentally just fixed for 15.7.

I'll verify this scenario was indeed fixed. Update: deleted the stack trace, as I accidentally looked at the wrong dump file... :-S

[jcouv]

Never mind, I accidentally debugged the wrong dump file. Here's the repeating portion of stack trace for this overflow:

• Symbols.FieldSymbol.Type.get() Line 55
• Symbols.BaseTypeAnalysis.DependsOnDefinitelyManagedType(Symbols.NamedTypeSymbol type, System.Collections.Generic.HashSet partialClosure) Line 167
• Symbols.BaseTypeAnalysis.IsManagedType(Symbols.NamedTypeSymbol type) Line 122
• Symbols.NamedTypeSymbol.IsManagedType.get() Line 424
• Symbols.SourceMemberContainerTypeSymbol.IsManagedType.get() Line 692
• Binder.BindNamespaceOrTypeOrAliasSymbol(Syntax.ExpressionSyntax syntax, Microsoft.CodeAnalysis.DiagnosticBag diagnostics, Roslyn.Utilities.ConsList basesBeingResolved, bool suppressUseSiteDiagnostics) Line 374
• Binder.BindTypeOrAlias(Syntax.ExpressionSyntax syntax, Microsoft.CodeAnalysis.DiagnosticBag diagnostics, Roslyn.Utilities.ConsList basesBeingResolved) Line 225
• Binder.BindType(Syntax.ExpressionSyntax syntax, Microsoft.CodeAnalysis.DiagnosticBag diagnostics, Roslyn.Utilities.ConsList basesBeingResolved) Line 205
• Binder.BindNamespaceOrTypeOrAliasSymbol(Syntax.ExpressionSyntax syntax, Microsoft.CodeAnalysis.DiagnosticBag diagnostics, Roslyn.Utilities.ConsList basesBeingResolved, bool suppressUseSiteDiagnostics) Line 346
• Binder.BindTypeOrAlias(Syntax.ExpressionSyntax syntax, Microsoft.CodeAnalysis.DiagnosticBag diagnostics, Roslyn.Utilities.ConsList basesBeingResolved) Line 225
• Binder.BindType(Syntax.ExpressionSyntax syntax, Microsoft.CodeAnalysis.DiagnosticBag diagnostics, Roslyn.Utilities.ConsList basesBeingResolved) Line 205
• Symbols.SourceMemberFieldSymbolFromDeclarator.GetFieldType(Roslyn.Utilities.ConsList fieldsBeingBound) Line 437
• Symbols.FieldSymbol.Type.get() Line 55

Note to self: private verify-overflow branch

[jcouv]

I'm taking this issue back because I have a fix in progress (verify-overflow private branch).

[vcsjones]

Another "report" of that here. https://stackoverflow.com/q/51732647/492405

[tomrus88]

Still not fixed in VS 16.0.0 Preview 4

[tomrus88]

Doesn't seems to crash on VS 16.8.0 Preview 3.2. Was it fixed?