search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.95k stars 4.02k forks source link

Intellisense diagnostics for projects selected not to be build in Configuration Manager #5647

Open mavasani opened 9 years ago

mavasani commented 9 years ago

Ported from VSO 96699

See the attached screenshots. Should we consider turning off intellisense diagnostics for such scenarios?

configurationmanagersetting errorlist

tmeschter commented 9 years ago

@mavasani What effect does that actually have on the build?

For example, if another project in that solution depended on SMBSimulator, wouldn't it still be built?

mavasani commented 9 years ago

Probably, it will build.

I think the possible fix we discussed is for the default error list "Project" column filter to be based on current solution configuration. We won't change any of our engines/drivers and the diagnostics will also exist in the system.

/cc @heejaechang for inputs.

tmeschter commented 9 years ago

So in that situation the diagnostics would appear from the build, but not from Intellisense? I'm not really thrilled by that.

Maybe we could filter them if it is disabled, and no other projects depend on it?

mavasani commented 9 years ago

@tmeschter The error list filter doesn't distinguish between build and intellisense, so error list will not show diagnostics from the project at all. However, the output window will have the diagnostics for the reference scenario you mentioned, and the error list filter can also be modified to show the build/intellisense diagnostics for the project.

heejaechang commented 9 years ago

Adding Andrew and David for input.

I think we first need to do how build behaves on such case and I think it might be something error list itself have to deal with ..

From: Manish Vasani [mailto:notifications@github.com] Sent: Friday, October 2, 2015 10:13 AM To: dotnet/roslyn roslyn@noreply.github.com Cc: HeeJae Chang Heejae.Chang@microsoft.com Subject: Re: [roslyn] Intellisense diagnostics for projects selected not to be build in Configuration Manager (#5647)

@tmeschterhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2ftmeschter&data=01%7c01%7cHeejae.Chang%40microsoft.com%7c0c286fc80abe4203176e08d2cb4cd2a4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=b5IDzn89aY3t%2bs4yevqyRLft7sxeDV7jPDPQnTFoNcY%3d The error list filter doesn't distinguish between build and intellisense, so error list will not show diagnostics from the project at all. However, the output window will have the diagnostics for the reference scenario you mentioned, and the error list filter can also be modified to show the build/intellisense diagnostics for the project.

— Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fdotnet%2froslyn%2fissues%2f5647%23issuecomment-145088660&data=01%7c01%7cHeejae.Chang%40microsoft.com%7c0c286fc80abe4203176e08d2cb4cd2a4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FCmMfahywOiQKgfpJlogM1GDNoGXNDMIbli0fBqw6%2b4%3d.