search

dotnet / roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/
MIT License
18.95k stars 4.02k forks source link

[Future branch] when possible, remove dynamic from host diagnostic manager #8837

Open heejaechang opened 8 years ago

heejaechang commented 8 years ago

currently we use dynamic here

http://source.roslyn.io/#Microsoft.VisualStudio.LanguageServices/Implementation/Diagnostics/VisualStudioWorkspaceDiagnosticAnalyzerProviderService.cs,fbeeb57381307200

and rely on that in here http://source.roslyn.io/#Roslyn.VisualStudio.Services.UnitTests/Diagnostics/MockExtensionManager.vb,a9887bafe72760db

the reason we do that is due to VS SxS issue with dev14 and dev v.Next.

once that issue is resolved, you should just use strong type there IVsExtensionManager rather than relying on dynamic to get around the issue.

heejaechang commented 7 years ago

@tmeschter when you moved all reference to d15, did you clean this one up?

heejaechang commented 7 years ago

not possible yet.