Open MaximLipnin opened 3 years ago
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
Those tests have been added recently in https://github.com/dotnet/runtime/pull/55625. They are skipped for WASM, I'm not sure if we want to do the same for Apple mobile platforms.
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti See info in area-owners.md if you want to be subscribed.
Author: | MaximLipnin |
---|---|
Assignees: | - |
Labels: | `area-System.Diagnostics.Tracing`, `untriaged` |
Milestone: | - |
@MaximLipnin Can you check to see what the value is for <EventSourceSupport>
?
@steveisok Something close to the mobile targets is https://github.com/dotnet/runtime/blob/main/eng/testing/tests.mobile.targets#L26 but we don't set EAT for the staging lanes so perhaps EventSourceSupport
is not set
Do we build with diagnostics tracing component support enabled when running tests on mobile, link or deploy needed components? I guess this tests will end up in ves_icall_System_Diagnostics_Tracing_EventPipeInternal_EventActivityIdControl and if we don't have component support loaded that will be a nop operation so won't set thread activity ID and that will trigger the assert in this test.
I don't think we do. We probably should skip these for the time being.
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger See info in area-owners.md if you want to be subscribed.
Author: | MaximLipnin |
---|---|
Assignees: | - |
Labels: | `area-System.Diagnostics.Tracing`, `os-android`, `os-ios` |
Milestone: | - |
Tagging subscribers to this area: @directhex See info in area-owners.md if you want to be subscribed.
Author: | MaximLipnin |
---|---|
Assignees: | - |
Labels: | `area-Infrastructure-mono`, `area-System.Diagnostics.Tracing`, `os-android`, `os-ios` |
Milestone: | - |
These are now enabled. Closing.
These are still failing on tvOS
cc @steveisok