dotnet / runtime

.NET is a cross-platform runtime for cloud, mobile, desktop, and IoT apps.
https://docs.microsoft.com/dotnet/core/
MIT License
14.9k stars 4.63k forks source link

[tvOS] Test failures in System.Diagnostics.Tracing.Tests #56073

Open MaximLipnin opened 3 years ago

MaximLipnin commented 3 years ago

cc @steveisok

dotnet-issue-labeler[bot] commented 3 years ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

MaximLipnin commented 3 years ago

Those tests have been added recently in https://github.com/dotnet/runtime/pull/55625. They are skipped for WASM, I'm not sure if we want to do the same for Apple mobile platforms.

ghost commented 3 years ago

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti See info in area-owners.md if you want to be subscribed.

Issue Details
- BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity ``` ``` - BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync ``` ``` - BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync ``` ``` - BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync ``` ``` cc @steveisok
Author: MaximLipnin
Assignees: -
Labels: `area-System.Diagnostics.Tracing`, `untriaged`
Milestone: -
steveisok commented 3 years ago

@MaximLipnin Can you check to see what the value is for <EventSourceSupport> ?

MaximLipnin commented 3 years ago

@steveisok Something close to the mobile targets is https://github.com/dotnet/runtime/blob/main/eng/testing/tests.mobile.targets#L26 but we don't set EAT for the staging lanes so perhaps EventSourceSupport is not set

lateralusX commented 3 years ago

Do we build with diagnostics tracing component support enabled when running tests on mobile, link or deploy needed components? I guess this tests will end up in ves_icall_System_Diagnostics_Tracing_EventPipeInternal_EventActivityIdControl and if we don't have component support loaded that will be a nop operation so won't set thread activity ID and that will trigger the assert in this test.

steveisok commented 3 years ago

I don't think we do. We probably should skip these for the time being.

ghost commented 3 years ago

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger See info in area-owners.md if you want to be subscribed.

Issue Details
- BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity ``` ``` - BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync ``` ``` - BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync ``` ``` - BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync ``` ``` cc @steveisok
Author: MaximLipnin
Assignees: -
Labels: `area-System.Diagnostics.Tracing`, `os-android`, `os-ios`
Milestone: -
ghost commented 3 years ago

Tagging subscribers to this area: @directhex See info in area-owners.md if you want to be subscribed.

Issue Details
- BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity ``` ``` - BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync ``` ``` - BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync ``` ``` - BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync ``` ``` cc @steveisok
Author: MaximLipnin
Assignees: -
Labels: `area-Infrastructure-mono`, `area-System.Diagnostics.Tracing`, `os-android`, `os-ios`
Milestone: -
steveisok commented 2 years ago

These are now enabled. Closing.

mdh1418 commented 2 years ago

These are still failing on tvOS