dotnet / templating

This repo contains the Template Engine which is used by dotnet new
https://docs.microsoft.com/dotnet/
MIT License
1.61k stars 368 forks source link

Dependency drift across .NET 8 and .NET 9 packages #8361

Open baronfel opened 1 week ago

baronfel commented 1 week ago

Product

dotnet CLI (dotnet new)

Describe The Bug

Chatted with @sayedihashimi and @phenning today about if/when VS should update to 9.x Template Engine packages, and we saw some discrepancies that are concerning.

.NET 8 package: image

.NET 9 package: image

The big problems I see are:

Were these on purpose? Do we need to have tests to pin the expectations of the VS host so we don't unwittingly violate them?

To Reproduce

N/A

dotnet Info

N/A

Visual Studio Version

No response

Additional context

No response

marcpopMSFT commented 1 week ago

So is the simple fix to just switch back to 472 and add back the System* dependencies? Do we have a pointer to when those got removed?

baronfel commented 1 week ago

maybe? I don't know when/why they were removed, so maybe it was a CG thing?