search

dotnet / vscode-csharp

Official C# support for Visual Studio Code
MIT License
2.88k stars 676 forks source link

Require .NET install value to always be passed #7775

Closed dibarbet closed 2 weeks ago

dibarbet commented 2 weeks ago

integration tests on .net6 were accidentally installing .net8 because one layer in the templates passed 'true' instead of the actual parameter value for 'installDotnet'.

Instead of having a boolean parameter, I switched this to require a string - and all layers of the templates now require the string to be passed, and only the top layer defines the value passed.

From the .NET 6 test run

.NET SDKs installed:
  6.0.428 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.36 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.36 [/usr/share/dotnet/shared/Microsoft.NETCore.App]