search

dotpcap / packetnet

Official repository - High performance .Net assembly for dissecting and constructing network packets such as ethernet, ip, tcp, udp etc.
Mozilla Public License 2.0
483 stars 104 forks source link

Added IGMPv3 Setters and Supporting Code #170

Closed jlshuman1961 closed 2 years ago

jlshuman1961 commented 2 years ago

Added Setters to MaxResponseTime and QueriersQueryInterval, and changed their types to ushort to handle converted values appropriately. Added supporting methods: getHighestOneBit() ConvertFloatingPointToCode()

jlshuman1961 commented 2 years ago

Chris Morgan sent me this in an email (but I didn't know how to do it):

"It should be pretty easy to up rev the library version, CI will push to nuget automatically.

I’d make that request once you’ve got the other things resolved. You could even open a pr with the changes to bump the rev to speed things along.

Chris"

PhyxionNL commented 2 years ago

Yeah, we can do that, I'll review now first.

jlshuman1961 commented 2 years ago

Does this mean that you can now bump the rev so that a new version of PacketDotNet can be released with the IGMPv3 support?

PhyxionNL commented 2 years ago

Yes, we can bump after needed changes in #160.