search

dottxt-ai / outlines

Structured Text Generation
https://dottxt-ai.github.io/outlines/
Apache License 2.0
8.34k stars 425 forks source link

Numpy > 1.26.4 #1104

Open Mikeriess opened 1 month ago

Mikeriess commented 1 month ago

What behavior of the library made you think about the improvement?

This issue is just meant as a Q&A, as I couldnt find anything specifically on this.

The question is why there is a dependency on older versions of numpy? What is the limitation in the newer numpy versions? And how big of a job do you estimate it would be to support newer versions of numpy?

How would you like it to behave?

Numpy > 1.26.4

lapp0 commented 1 month ago

@Mikeriess I don't think it would be a substantial effort.

We pinned to numpy 1 due to

The imports would need to be fixed. Unless there's something I'm missing this is a trivial change.

Mikeriess commented 3 weeks ago

Got it. Have had some compatibility issues with outlines and the newest llama.cpp version due to this, so if this is a trivial change that is great news 👍

lapp0 commented 3 weeks ago

Got it. Have had some compatibility issues with outlines and the newest llama.cpp version due to this, so if this is a trivial change that is great news 👍

Is the latest llama.cpp incompatible with numpy<2.0.0? If so, could you please share your error?

I'd like to ensure this is high priority if it breaks the latest llama.cpp.

smallstepman commented 3 weeks ago

https://github.com/abetlen/llama-cpp-python/blob/9769e5719ad45d4be6bc3ebe01d0f568d3d5001e/pyproject.toml#L16

https://github.com/vllm-project/vllm/blob/5231f0898e559671c6c8cc48efc53a859fce1841/requirements-common.txt#L3

looks like everyone is lagging behind