search

doublesymmetry / react-native-track-player

A fully fledged audio module created for music apps. Provides audio playback, external media controls, background mode and more!
https://rntp.dev/
Apache License 2.0
3.3k stars 1.02k forks source link

Update React Native to 0.76.2 #2395

Open puckey opened 2 weeks ago

puckey commented 2 weeks ago
lovegaoshi commented 2 weeks ago

pls note https://github.com/doublesymmetry/react-native-track-player/pull/2370 breaks on rn <0.76.1

smfunder commented 5 days ago

I came here to see what would be the progress for this PR to be merged? Would it fully work with RN 0.76.1 is there any help I can provide to try it out?

puckey commented 4 days ago

I updated the example app to 0.76.2, which should have fixed the remaining timer issues through https://github.com/facebook/react-native/commit/ee7b4e276355146be53958b402bfb2d5af2dd1bc. @smfunder would you like to verify?

smfunder commented 4 days ago

@puckey what would be the best way to try it out? Should I clone the library on this PR's branch and then replace my node_modules/react-native-track-player folder with the content of it?

lovegaoshi commented 4 days ago

u should clone and start testing the example app.

if ur absolutely sure to test in ur own app, do note newarch breaks/bugs many libs right now, so if it doesnt work u shouldnt comment on this PR but the respective libs.

u should first make sure ur project uses RN 0.76.2. then for RNTP instead of a version, use this PR's SHA. for example https://github.com/lovegaoshi/azusa-player-mobile/blob/e3ce4f61806075ce5d6458748b570e9733c7fc2a/package.json#L113. but use this PR's SHA instead

smfunder commented 4 days ago

thank you @lovegaoshi I will try it asap and get back to you here!