search

douglytle / group31-minisurveymonkey

0 stars 0 forks source link

Implemented User Account Creation and Login #25

Closed douglytle closed 2 weeks ago

douglytle commented 2 weeks ago

I have implemented user account creation and login features, as per Issue #11. This includes various templates, a new controller, and a new persistence entity, the "user". I have not yet implemented related features such as surveys belonging to users, but will update the issues list with these related facets of user account functionality.

Sgt-Roukoz commented 2 weeks ago

Looks good so far, one small thing you could do to show login however, is hide the create survey link if you are not logged in (but show account creation/login), then show the create survey link if you are logged in (hiding account creation/login, replacing it with a user profile or something). We should have some indicator in each relevant page of you being logged in currently (maybe in the top right of the page have a "Logged in as: X" tag)

You should add a Back to Homepage link in the login page.

douglytle commented 2 weeks ago

I have implemented all of your requested changes. The user login status is now stored using an HttpSession object. The links displayed to the user on the home page will change depending on if they are logged in, and there is text on screen which displays the current account or informs the user they are not logged in. I have also added a log out feature, and added more links for navigation between pages as requested.

Sgt-Roukoz commented 2 weeks ago

Everything looks good so far, but I would recommend adding tests for the new model additions.

douglytle commented 2 weeks ago

Unit Tests for the new additions have been implemented