search

dougshidong / PHiLiP

Parallel High-Order Library for PDEs through hp-adaptive Discontinuous Galerkin methods
Other
45 stars 36 forks source link

Optimizing build #257

Open acse-bn20 opened 4 months ago

acse-bn20 commented 4 months ago

I changed make to ninja. This results in 20-30% faster build time than the previous one. It successfully compiled on Narval.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

jbrillon commented 4 months ago

Since this is your first PR, post the ctest results and we'll merge it

acse-bn20 commented 4 months ago

output_ctest.log I uploaded the local ctest results.

cpethrick commented 4 months ago

There are a few tests failing which usually don't fail (at least to the best of my knowledge!). Could you confirm the behaviour of the following tests?

1D_TIME_REFINEMENT_STUDY_ADVECTION_IMPLICIT 1D_DIFFUSION_BR2_IMPLICIT_MANUFACTURED_SOLUTION ANISOTROPIC_MESH_ADAPTATION_SSHOCK (** this one may be due to your GMSH version if I recall correctly. It may pass if you change to GMSH 4.11.1.; see discussion on the test cases channel on discord. If you have a different GMSH, it's fine to leave this failing)

I checked and these tests pass on the current master.