Open loynoir opened 2 years ago
Will have to look into this.
Hi, this is just a review from a fellow docker official image maintainer in the hope that when this gets to review its going to be easier and quicker to approve:
Per https://github.com/docker-library/official-images/blob/master/NEW-IMAGE-CHECKLIST.md
on https://github.com/docker-library/official-images/blob/master/README.md#review-guidelines
dovecot -F
is essentially doing the same as tini may was well use that. It doesn't process SIGQUIT, but I think the SIGTERM which works fine.DEBIAN_FRONTEND=noninteractive apt-get install ...
for minimal scope.container=docker
- unsure whyLC_ALL=C
unsure why. Thought build environment was clean with respect to this.Hi! Thank you for the informal review, some comments for it:
I guess it's something like
https://github.com/docker-library/official-images/tree/master/library
https://github.com/docker-library/official-images/blob/master/library/postfixadmin