downpouring / csharp-sqlite

Automatically exported from code.google.com/p/csharp-sqlite
Other
0 stars 0 forks source link

publicizing methods for use in Mono.Data.Sqlite #162

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I am in the process of creating a Mono.Data.Sqlite assembly for 
Silverlight/Windows Phone/WinRT and all is going very well. 
I can use the Community.CsharpSqlite assembly and the Mono.Data.Sqlite source 
code from the official Mono github repo. However, I am having a small problem 
with 6 static methods: their visibility.

I have attached a patch that only modifies the signature (visibility) of the 6 
methods. It would be very cool if this could be applied to the official version 
of csharp-sqlite. This will remove the need for using a custom build.

I am hoping to provide a almost identical Mono.Data.Sqlite assembly that can be 
swapped without any code changes depending on the platform.

I hope for some feedback soon.

Original issue reported on code.google.com by mattleib...@gmail.com on 23 Jun 2012 at 3:40

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by noah.hart@gmail.com on 23 Jun 2012 at 4:18

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 86a3ba530d65.

Original comment by noah.hart@gmail.com on 23 Jun 2012 at 4:20

GoogleCodeExporter commented 9 years ago
Cool, thanks very much.
Just as a side note, is there a reason why the SQLITE_ENABLE_COLUMN_METADATA 
build condition is not included by default? Another problem that I had was with 
the DataAdapters and Schemas. As they need some of the functions that are under 
that build condition, I had to add that condition. Is the implementation not 
fully complete or something? There seemed to be no problems when I enabled it.

Original comment by mattleib...@gmail.com on 23 Jun 2012 at 6:44