downthecrop / betterdgg

Better Better Destiny.gg // Make Destiny.gg Great Again!
http://downthecrop.xyz/bbdgg
Other
2 stars 3 forks source link

Highlightfix #60

Closed PinkishCow closed 8 years ago

PinkishCow commented 8 years ago

Ignore the commit autism, this doesn't work in the backlog, fuck knows why.

Fixes #55 again.

kenany commented 8 years ago

No idea what's going on here

PinkishCow commented 8 years ago

After a total of 4 and a quarter hours, neither do I, it needs to be in 2 wraps of jquery, i found that from a page 2 google result, and it all looked like this at one point http://puu.sh/qnYFE/39b1daf73f.png and http://puu.sh/qnVMt/6c27813da3.png All i know is it works 100% with both capitalised and lowercase names. But it doesn't work in the backlog. just because it feels like

PinkishCow commented 8 years ago

Also gui.toggleUserFocus just didn't feel like having any of it so i had to copy the code out of it and do it manually once i managed to get the names that it needed to focus

PinkishCow commented 8 years ago
var users = gui.lines.find(".chat-user:contains(" + username + ")"); 

This works in some cases but not others

Chat handles the clicking off itself because we use the same stuff they do

Using the predefined gui thing does not, I tested that when i first did it and tested it just now too.

Tried taking this out as a variable, did not work, not a clue why.

($($(users)[0].parent().parent()[i]).find(".user").text().toLowerCase())

Also gui.toggleUserFocus() already exists in the chat but it doesn't work no matter how hard you try with both the older version and the newer version.

kenany commented 8 years ago

Alright, I'll take another look at this Saturday or something. Might not be needed anyways in light of https://github.com/BryceMatthes/betterdgg/issues/55#issuecomment-247164036?

PinkishCow commented 8 years ago

Yeah it could also be the fault of it being 5am :P And yeah, that does fix the issue but personally i would like it to use the same method as the chat uses by default, as it does here, just incase.