Made some changes to make this work on safari.

[david-cako]

Been using safari lately and realized that this exists but doesn't work.

SweetieBelle's namecolor module uses let, which does not seem to be implemented in Safari 9.*, and doesn't seem to have any apparent use in this case (I don't see anywhere that the hoisting would hurt anything).

I don't know the d.gg/bdgg codebase well enough to know what's going on with stalk.js. self.on() errors, telling me that self has no function on(). Window.on() works (these are synonymous, right?), but I get console errors at window.postMessage(obj, '*'); and self.postMessage(obj) with "An invalid or illegal string was specified.". I don't know what object is being passed into these and didn't look too much into it, because the rest of the extension works.

Finally, the callback explaining how to install it never fires for some reason. I would assume that if the merge fails, execution stops anyway.

I may have a signing certificate for you too.

[PinkishCow]

Been using safari lately

There's your issue right off the bat, get a real computer. PEPE

I don't know the d.gg/bdgg codebase well enough to know what's going on with stalk.js.

Neither do we

don't know what object is being passed into these

Same

Literally anyone but @KenanY when they work on this looks a bit like this

TBH I never knew it actually worked on safari as is, nevermind with any new stuff, I don't think anyone else actually bothered to build it before. GL 👌

[kenany]

@david-cako I don't know anything about OSX or Safari, but shouldn't everyone be on Safari 10 by now (maybe I'm being optimistic)?

As for everything else, I'll have to look more into it later. Hardest part is getting Safari on Linux :(

[david-cako]

My work machine is a hackintosh and I am admittedly running an older version of macOS (10.11.5) to avoid the hassle of things breaking, so that's my fault. Still, there doesn't seem to be a reason for "let".

On Feb 8, 2017, at 20:43, Kenan Yildirim notifications@github.com wrote:

@david-cako I don't know anything about OSX or Safari, but shouldn't everyone be on Safari 10 by now (maybe I'm being optimistic)?

As for everything else, I'll have to look more into it later. Hardest part is getting Safari on Linux :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kenany]

True, in that case I'm fine with getting rid of let here.

[david-cako]

@KenanY margin-top: -30px; was not set as !important on bdgg emotes and was being overridden in safari by the .chat-emote styles. A build with this change was tested in chrome and nothing seems to be affected there.

[9inevolt]

It used to kind of work on Safari but alot of the background page features like stalk and flag flairs didn't because of how Safari handles CSP. Also only one person in chat used it on Safari before so it wasn't worth maintaining.

Also, as you noticed, Safari handles user styles a little differently than other browsers and often required !important flags in many places.

[downthecrop]

I appreciate the work but we're dealing with a very small amount of users here. Personally I'm not interested in maintaining Safari compliant JS every patch if it's going to cause any headache.

If !important in CSS and let are the only two big issues currently I think we're cool. I won't be enforcing Safari functionality testing for features though.