dpa99c / cordova-diagnostic-plugin

Cordova/Phonegap plugin to manage device settings
540 stars 361 forks source link

Add ability to open notification settings on Android #434

Closed CasperVerswijvelt closed 3 years ago

CasperVerswijvelt commented 3 years ago

PR Type

What kind of change does this PR introduce?

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

What is the purpose of this PR?

Add possibility to open notification settings on android devices running Android O or above. Android versions lower than O will fall back to just the app details page. Requested in issue #351.

Does this PR introduce a breaking change?

What testing has been done on the changes in the PR?

Added function has been tested on different Android versions

What testing has been done on existing functionality?

Existing features were tested to be still working

ghost commented 3 years ago

DeepCode's analysis on #94fd99 found:

Description Example fixes
Use the rest parameters instead of 'arguments'. Occurrences: :wrench: Example fixes
Expected an object to be thrown. Occurrences: :wrench: Example fixes
Missing JSDoc @return for function. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

CasperVerswijvelt commented 3 years ago

Bump for stale bot