search

dpacassi / disable-javascript

Adds the ability to disable JavaScript on specific sites.
MIT License
275 stars 35 forks source link

bug: whitelisting investing.com not working #47

Closed woj-tek closed 6 years ago

woj-tek commented 6 years ago

For some reason with extension enabled the chart is not loading.

dpacassi commented 6 years ago

Hi @woj-tek!

Thanks for your report. The web extension works as itended - it allows JavaScript which is loaded by the domain or any sub domain. In your particular case however, the chart is being included via iframe and the web extension currently handles iframes as separate domains and therefor correctly blocks JavaScript in the iframes themselves.

But, people may miss this information and in this regard you're completely right. This issue will be fixed in the future with #41.

There's a workaround for your fix though - the charts are coming from the akamaized.net domain, so simply add this domain (with the subdomains option enabled) to the whitelist and you should be able to see the charts!

If you want to speed things up, please keep in mind that contribution in any form (pull request or PayPal) are welcome at any time!

woj-tek commented 6 years ago

Thank you - it worked like a charm :-)