search

dpc10ster / RJafroc

Artificial Intelligence: Evaluating AI, optimizing AI
19 stars 8 forks source link

Fix C++ error in erf function #4

Closed pwep closed 5 years ago

pwep commented 5 years ago

Rename the erf function is renamed to erfcpp and exposed to R. The R implementation is renamed erf_R, and kept for future performance testing.

This pull request is against Dev's development branch, rather than master, and should go some way to addressing the CRAN error.

codecov[bot] commented 5 years ago

Codecov Report

Merging #4 into development will increase coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development      #4      +/-   ##
==============================================
+ Coverage         0.08%   0.08%   +<.01%     
==============================================
  Files               56      56              
  Lines             7325    7323       -2     
==============================================
  Hits                 6       6              
+ Misses            7319    7317       -2
Impacted Files Coverage Δ
R/PlotRsmOperatingCharacteristics.R 0% <0%> (ø) :arrow_up:
src/RsmFuncs.cpp 1.51% <0%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cc50c3...6cc7d85. Read the comment docs.