pwep commented 3 years ago

Fixes #65 R-devel (4.1.0) has modified the behaviour of all.equal(), which is used by v2.x of testthat for equality testing. R-devel now checks the environment as part of the equality test.

This update disables the environment check explicitly for each equality test on the ggplot2 output by adding the variable check.environment = FALSE in these functions.

The testthat package is introducing some breaking changes in version 3.x.x., known as the 3rd Edition.

https://testthat.r-lib.org/articles/third-edition.html

The expect_equal() function will use waldo::compare() rather than the all.equal() function.

codecov[bot] commented 3 years ago

Codecov Report

Merging #67 (4e7cc76) into developer (592042d) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff             @@
##           developer      #67   +/-   ##
==========================================
  Coverage      73.66%   73.66%           
==========================================
  Files             81       81           
  Lines           9820     9820           
==========================================
  Hits            7234     7234           
  Misses          2586     2586

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 592042d...4e7cc76. Read the comment docs.

dpc10ster commented 3 years ago

Thanks for getting to the bottom of this. Interesting problem.

dpc10ster / RJafroc

Update plot-based expect_equal() tests #67

Codecov Report