dpc10ster / RJafroc

Artificial Intelligence: Evaluating AI, optimizing AI
19 stars 8 forks source link

rhub check failures 1 off xx on cran4a branch: polygon not found error in vignette #75

Closed dpc10ster closed 2 years ago

dpc10ster commented 2 years ago

I am in the process of a CRAN submission. See inst\cranSubmission\cranSubmission.R below, which runs the checks on different platforms: here I focus on the checks run on the "macos-m1-bigsur-release" platform (other failures will be posted as separate issues). Code is on branch cran4a.

chk3 <- rhub::check(packagePath, platform = platforms[[1]][3])

Here is file inst\cranSubmission\cranSubmission.R:

library(devtools)
library(rhub)
library(RJafroc)

platforms <- rhub::platforms()
# > platforms[[1]]
# "macos-highsierra-release"      
# "macos-highsierra-release-cran" 
# "macos-m1-bigsur-release"       
# "solaris-x86-patched"          
# "solaris-x86-patched-ods" 

packagePath <- "/Users/Dev/GitHub/RJafroc_2.1.0.tar.gz"
if (!file.exists(packagePath))
 packagePath <- devtools::build()

# devtools::check_win_devel(packagePath) #OK
# devtools::check_win_release(packagePath) #OK
# devtools::check_win_oldrelease(packagePath) #OK
# devtools::revdep() # NONE

# chk1 <- rhub::check(packagePath, platform = platforms[[1]][1]) # OK
# chk2 <- rhub::check(packagePath, platform = platforms[[1]][2]) # OK

chk3 <- rhub::check(packagePath, platform = platforms[[1]][3]) # FAILS with message shown next

And here is the relevant output:

W  checking re-building of vignette outputs (5s)
 W  checking re-building of vignette outputs (7.7s)
   Error(s) in re-building vignettes:
     ...
   --- re-building ‘Ch19Vig1FrocSampleSize.Rmd’ using rmarkdown
   Quitting from lines 145-155 (Ch19Vig1FrocSampleSize.Rmd) 
   Error: processing vignette 'Ch19Vig1FrocSampleSize.Rmd' failed with diagnostics:
   polygon edge not found
   --- failed re-building ‘Ch19Vig1FrocSampleSize.Rmd’

   --- re-building ‘Ch19Vig2FrocSampleSize.Rmd’ using rmarkdown
   --- finished re-building ‘Ch19Vig2FrocSampleSize.Rmd’

   SUMMARY: processing the following file failed:
     ‘Ch19Vig1FrocSampleSize.Rmd’

   Error: Vignette re-building failed.
   Execution halted
pwep commented 2 years ago

polygon edge not found appears to be coming from ggplot2. I will take a look and report back.

pwep commented 2 years ago

Just checking in on this issue. As you can see from the error message Ch19Vig2FrocSampleSize.Rmd builds and rebuilds OK. It is the two charts created in Ch19Vig1FrocSampleSize.Rmd which are causing the error, so ggplot2-related.

Still hunting for the underlying cause on the M1 platform.

dpc10ster commented 2 years ago

Deleting the vignettes will fix these.