Missing expect_known_output test in for DfBinDatasetAFROC (test-data-file.R)

dpc10ster / RJafroc

Artificial Intelligence: Evaluating AI, optimizing AI

19 stars 8 forks source link

Missing expect_known_output test in for DfBinDatasetAFROC (test-data-file.R) #9

Closed pwep closed 5 years ago

pwep commented 5 years ago

The following test creates a new tempfile of output, but does not repeat DfBinDatasetAFROC to compare.

https://github.com/dpc10ster/RJafroc/blob/8c0602ff19772770fdea1029ce65ce82e050fb2e/tests/testthat/test-data-file.R#L83-L88

pwep commented 5 years ago

Alternatively, is that the intention of the test? Just to check that the data is generated once and the file produced without errors? (rather than produce it twice, and compare the outputs)

I have found other test files where a new tempfile name is created, but only written to once using expect_known_output.

tests/testthat/test-StSignificanceTestingCad.R
tests/testthat/test-datasets.R

dpc10ster commented 5 years ago

I am going to close this issue as your fix takes care of these spurious warnings. Thank you Peter.