search

dpgaspar / Flask-AppBuilder

Simple and rapid application development framework, built on top of Flask. includes detailed security, auto CRUD generation for your models, google charts and much more. Demo (login with guest/welcome) - http://flaskappbuilder.pythonanywhere.com/
BSD 3-Clause "New" or "Revised" License
4.69k stars 1.36k forks source link

Adding last_login to FAB for Superset #2124

Open sfirke opened 1 year ago

sfirke commented 1 year ago

I'd like to implement https://github.com/apache/superset/discussions/22185#discussioncomment-7190757, adding a last-logged-in field to Apache Superset. As far as I can tell, Superset imports UserModelView from FAB and uses it as-is. So if this modification to the default could happen in FAB, it would involve a tiny change, but if Superset broke from FAB here it would involve copying a lot of FAB code that would then be harder to maintain.

Is that correct? If so, are you open to adding last_login as a default displayed field in FAB? And is that addition as simple as I've laid out in my linked comment above?

Thanks for considering!

dpgaspar commented 1 year ago

Could be a nice addition as long as it fits well on the table, feel free to open a PR.