search

dpryan79 / MethylDackel

A (mostly) universal methylation extractor for BS-seq experiments.
MIT License
164 stars 44 forks source link

Fixed segfault with mappability filtering, minor fixes. #120

Closed Valiec closed 3 years ago

Valiec commented 3 years ago

I had found a segfault that was happening irregularly when calling methylation (i.e. MethylDackel extract) with mappability filtering turned on (it was fine when filtering was turned off though). I made two fixes for out-of-bounds memory accesses here, and one or both of them fixed it (I don't know for sure which one did it).

I also fixed a minor typo in the usage message ("BB" instead of "BBM" in 2 spots), and a segfault with an invalid combination of options (specifically, -O (output BBM) without -M (input mappability bigWig)).

dpryan79 commented 3 years ago

Thanks @Valiec !

dpryan79 commented 3 years ago

BTW, I'll be pushing out version 0.6.0 including this shortly