search

dr5hn / countries-states-cities-database

🌍 Discover our global repository of countries, states, and cities! 🏙️ Get comprehensive data in JSON, SQL, PSQL, XML, YAML, and CSV formats. Access ISO2, ISO3 codes, country code, capital, native language, timezones (for countries), and more. #countries #states #cities
https://dr5hn.github.io/countries-states-cities-database/
Open Data Commons Open Database License v1.0
7.55k stars 2.6k forks source link

Fix translations languages #883

Closed mtsfer closed 1 month ago

mtsfer commented 1 month ago

Reference: #868

Also fixes korean language code. The correct one is "ko".

Closes: #854

dr5hn commented 1 month ago

@mtsfer i think it should be

zh-cn and ko-kr respectively.

zh is the parent language code and cn is sub language code.

mtsfer commented 1 month ago

@dr5hn I've found this discussion about Chinese variations, and zh-CN is indeed the better option.

However, I wasn't able to find any reliable resource about ko-KR. Based on here, ko is the standard Korean, ko-KP is the North Korea variation and ko-KR is the South Korea variation.

Defaulting to ko while not sure which variation is being used on Korean translations wouldn't be a safer move here?

dr5hn commented 1 month ago

@mtsfer Agree with keeping ko as is and changing zh to zh-cn. Please make required changes and rebase the branch.

Thanks so much for your active participation and all the work you're doing.

dr5hn commented 1 month ago

@mtsfer Could you please rebase you branch and resolve conflicts?

mtsfer commented 1 month ago

@dr5hn Sorry for the late reply. I'm working on this right now.