Fix Diffs hard to read with cursorline over text

dracula / vim

🧛🏻‍♂️ Dark theme for Vim

https://draculatheme.com/vim

MIT License

1.34k stars 454 forks source link

Fix Diffs hard to read with cursorline over text #285

Open sprloth opened 2 years ago

sprloth commented 2 years ago

Fix the problem Diffs hard to read with cursorline over text, https://github.com/dracula/vim/issues/130

benknoble commented 2 years ago

Looks like a reasonable change, but it will be a while before I can test it. Do you have a screenshot or two?

sprloth commented 2 years ago

before 屏幕截图 2022-05-23 204305

after 屏幕截图 2022-05-23 204554

benknoble commented 2 years ago

Hi, sorry about the delay; just a heads up that this is still in my backlog of things to do and I haven't forgotten about it.

If @dsifford has time to test and approves than I trust their decision, too.

benknoble commented 2 years ago

Sorry again for the delay: I just took at the issue you describe, and it doesn't happen when you don't use cursorline—how does your fix impact nocursorline? Can you share a screenshot (before/after would be great for posterity) without cursorline so we can verify that it doesn't break anything?