dracula / vim

🧛🏻‍♂️ Dark theme for Vim
https://draculatheme.com/vim
MIT License
1.34k stars 454 forks source link

Disable background highlighting of `DraculaDiffDelete` when appropriate #306

Closed speelbarrow closed 1 year ago

speelbarrow commented 1 year ago

Disable the background highlight for the DraculaDiffDelete group when:

Before:

Screenshot 2023-05-25 at 11 26 25 AM

After:

Screenshot 2023-05-25 at 11 27 48 AM
benknoble commented 1 year ago

Can you share a different diff? In that particular one I think the contrast in the first screenshot is tremendously helpful.

dsifford commented 1 year ago

Agree with @benknoble. I feel like having the contrast where an entire line is deleted helps people easily see where deletions occur.

speelbarrow commented 1 year ago

That's a fair point. I'm more-so thinking about the background on the symbol in the signs column, but that's something I can take up with the maintainers of that plugin. I'll go ahead and close this PR.

speelbarrow commented 1 year ago

Reopening -- I didn't realize Dracula set the GitSigns groups itself. Currently working on a way to override just GitSignsDelete to lose the bg in the same cases as above.

benknoble commented 1 year ago

Can you change the PR to just drop the reverted commit? No need for the noise in the history. (You can do this with an interactive rebase, for example.)

speelbarrow commented 1 year ago

Can you change the PR to just drop the reverted commit? No need for the noise in the history. (You can do this with an interactive rebase, for example.)

Dropped. Here are new before and after screenshots (changed the Terminal background to make the change more visible):

Before:

Screenshot 2023-05-25 at 3 05 42 PM

After:

Screenshot 2023-05-25 at 3 07 19 PM
benknoble commented 1 year ago

The visual changes LGTM. Still dealing with code indent.

@dsifford ?

dsifford commented 1 year ago

I'm cool with it if you are @benknoble (pending fixes to formatting)

speelbarrow commented 1 year ago

Formatting issues resolved. Sorry about the indent, didn't realize it got cut out when I squashed the commits.