search

dradovic / MigSharp

Mig# (MigSharp) is a .NET framework for database migrations and versioning
Other
106 stars 34 forks source link

Allow Extension of Existing Providers #54

Closed JonathanDCrowe closed 9 years ago

JonathanDCrowe commented 10 years ago

I had a case where I wanted to customize the functionality of a single method of one of the providers. Since the class is marked internal it is not possible to override a single method. Also, since the helpers are also internal we couldn't just copy the code for that one provider & customize it.

So I'd like to request that the providers be made public and that the methods be marked virtual to allow for extension.

dradovic commented 10 years ago

That's an interesting idea. Yes, the current version of Mig# was not written to be extensible in that respect. Having the providers public and their methods virtual would not suffice of course as the overriden provider classes would have to be discovered and instantiated by Mig#.

dradovic commented 9 years ago

Closing this issue for now as there has not been any traction.

JonathanDCrowe commented 9 years ago

I ended up modifying the source on my own to get this to work. Thanks for at least considering the idea for your project.

On Wed, Jul 1, 2015 at 7:05 AM, dradovic notifications@github.com wrote:

Closing this issue for now as there has not been any traction.

— Reply to this email directly or view it on GitHub https://github.com/dradovic/MigSharp/issues/54#issuecomment-117635452.