search

dragnet-org / dragnet

Just the facts -- web page content extraction
MIT License
1.26k stars 180 forks source link

publish a new release on pypi? #84

Closed bdewilde closed 5 years ago

bdewilde commented 5 years ago

Hi! It's been about a year since the last release — and my previous ask for it ;) — and I was wondering if folks had bandwidth to publish a new (v2.0.4?) release to pypi. It would be great to get unblocked on upgrading scikit-learn to v0.20. Thanks in advance!

matt-peters commented 5 years ago

I'm all for pushing a new release. Who has access to create a new release other then me? It would also be great to have someone review and merge in the two open PRs before the new release.

bdewilde commented 5 years ago

That's a good question... @pakelley or @b4hand , maybe?

pakelley commented 5 years ago

I don't have permission to merge or release a package, but I'd be happy to help review those PRs if you want @matt-peters

bdewilde commented 5 years ago

Would either of you like to have permissions to merge PRs and publish releases? If so... @matt-peters , would you be able to grant them? I'd volunteer but I'm not confident that I have enough bandwidth to maintain another project... Maybe I can be a backup plan? :)

pakelley commented 5 years ago

Yeah, I'd be happy to help out with that if @matt-peters is open to it

b4hand commented 5 years ago

I looked at both open PRs, but I'm not sure if either is ready to merge. It's probably better to just go ahead and create a new release. I can grant permissions to the project if @matt-peters approves.

matt-peters commented 5 years ago

I'm all for adding additional collaborators with write access to the repo, and ability to push a new release to pypi. My bandwidth for maintaining this is pretty low at this point, but it is still fairly actively used as far as I know.

bdewilde commented 5 years ago

Hi @matt-peters , just following up on this. Could you grant repo write access to @pakelley, and make him a maintainer of the package on pypi? If you'd like an additional pair of helping hands, I volunteer as tribute, and will coordinate with Patrick.

b4hand commented 5 years ago

I've granted @bdewilde and @pakelley write access to the repo.

b4hand commented 5 years ago

I can grant access to pypi, but I'll need your usernames there. I couldn't find either of you listed as @bdewilde and @pakelley.

bdewilde commented 5 years ago

Thanks a ton, @b4hand ! On PyPi, I'm @bjdewilde.

b4hand commented 5 years ago

bjdewilde has been added to pypi.

bdewilde commented 5 years ago

Alright! Let's see now about publishing a minor 2.0.4 release. Is there anything special that has to be done for the cython files? If not, here's a checklist:

Anything I've missed here?

pakelley commented 5 years ago

I didn't have my own PyPi account before, but I created one (@pakelley). I'll be away for the rest of this week, but I can help out with preparing the release next week 👍

matt-peters commented 5 years ago

Awesome, thanks everyone for taking this on! I can't remember the details regarding the cython files, but don't think there was anything special as they are distributed with the package and built locally on installation.

b4hand commented 5 years ago

Probably a good idea to put the release instructions in the README just so we don't forget later. It's always a pain to try to figure it out when you just want to make a release quickly.

b4hand commented 5 years ago

pakelley is added to pypi as well

bdewilde commented 5 years ago

Just a heads-up: I've gotten through all the steps except for publishing the release on PyPi and tagging it here on GitHub. I built a source distribution as well as PY2 + PY3 wheels, and all existing tests pass, so I'm assuming that everything is okay.

Apologies in advance if I've screwed something up. 🙏

bdewilde commented 5 years ago

PyPi: https://pypi.org/project/dragnet/#history GitHub: https://github.com/dragnet-org/dragnet/releases/tag/2.0.4