dragnilar / Databvase

A (sorta) lightweight query tool for MS Sql Server that makes usage of DevExpress to provide a rich user interface
3 stars 1 forks source link

Direct X Settings Changed Message Displays When Opening The Settings Menu Even Though The User Has Not Actually Tried To Change It #39

Closed dragnilar closed 6 years ago

dragnilar commented 6 years ago

Repro Steps:

Possibly optional pre-req: You may need to have enabled Direct X prior to performing the steps below.

  1. Open Databvase
  2. Open the settings menu Result: You will receive a pop up telling you that the direct x settings have been changed, blah blah blah. However you did not actually click on the check box to change anything, YET.

Reason: The event in the VM always fires whenever the data binding changes. Since the value for UseDirectX is being set in the constructor, the event detects a change and fires.

Change: For now I added an additional window state to the VM so that it first goes through a "loading" state before it sets the state to "shown". Subsequently the event for the direct x setting will only display the message if the window is actually shown. This isn't exactly the most ideal solution but I don't feel like spending a lot of time on this since this is more of a minor annoyance than anything else.

dragnilar commented 6 years ago

Fixed with 17dc2e02