dragoonDorise / EmuDeck

Emulator configurator for Steam Deck
GNU General Public License v3.0
2.85k stars 209 forks source link

If we have Primehack... can we get Project Plus? Other forks? #431

Open jacfalcon0 opened 1 year ago

jacfalcon0 commented 1 year ago

Since a fork of Dolphin, Primehack, was included, is there any chance that other forks of emulators might be included? Such as Project Plus (Super Smash Bros Brawl online)?

WingofaGriffin commented 1 year ago

The core installer difference here is installing a forked Ishiiruka Dolphin app image used to improve performance and have consistent netplay versions across users.

That said, there is consideration to take in installing Ishiiruka Dolphin as a performance booster emulator if we have data showing it improve performance for games other than P+/Melee.

The original Ishiiruka is abandoned: https://github.com/Tinob/Ishiiruka The Ishiiruka fork used by Faster P+: https://github.com/jlambert360/Ishiiruka The Ishiiruka fork used by Slippi Melee: https://github.com/project-slippi/Ishiiruka

Given that Ishiiruka is supposed to focus on performance over accuracy and stability, it isn't unreasonable to consider Ishiiruka would have benefits on Deck. https://emulation.gametechwiki.com/index.php/Ishiiruka-Dolphin. The question in my eyes is do these forks offer the same improvements to other games, or are they specific to the games they were forked for. @jacfalcon0 are you willing to do some testing and reporting with findings?

jacfalcon0 commented 1 year ago

@jacfalcon0 are you willing to do some testing and reporting with findings?

I wish I had the time at the moment, but I might circle back later.

Godsbane commented 1 year ago

I'm willing to look at this just as is from a download / setup standpoint, after we get the next release out. It would be a very much optional setup, and may not be able to be integrated outside of making launcher for steam rom manager to scrape. Will need to research first.

tassyguy commented 1 year ago

Hey I was just looking into this feature as well, if it's ok I would like to take a look at implementing this feature as an optional step for EmuDeck? I have an idea of what may need to be done to make it work

Godsbane commented 1 year ago

Feel free. Fork the beta repository :)

rubengc commented 1 year ago

Would be awesome to have Project Plus and Slippi 😍

As suggestion, Emudeck could have 2 emulators screens, one for official emulators and another one with the custom ones

I installed PrimeHack without meet what is for and when I searched about it just decided to give it try since I love that idea

WingofaGriffin commented 1 year ago

This is something that is a bit more finicky than a simple Emulator setup. See the gist I made (also linked in the wiki) for instructions: https://gist.github.com/WingofaGriffin/3202698447ca2452a9431137cfc18d21