search

dragozzine / multimoon

fit solar system small body multiple systems with non-Keplerian orbits including quadrupole shapes
MIT License
4 stars 0 forks source link

Spin vector not properly treated #12

Closed benp175 closed 3 years ago

benp175 commented 3 years ago

https://github.com/dragozzine/multimoon/blob/b1c16687dd40534a8f2b751c3911bff74019b13f/src/mm_SPINNY/spinny_nosun.py#L183

The spin vector, which ultimately goes into the plots (and possibly other things?), isn't properly pulled from the integration. It just takes the final spin state repeatedly.

Assigning this to myself and just using this to track the issues I come across.

benp175 commented 3 years ago

Same issue present in this line:

https://github.com/dragozzine/multimoon/blob/b1c16687dd40534a8f2b751c3911bff74019b13f/src/mm_SPINNY/spinny_nosun.py#L195

Should be easy to fix. The spin state just needs to be retrieved during the integration, not after.

benp175 commented 3 years ago

Now fixed.