search

drahak / Restful

Drahak\Restful - Nette REST API bundle
0 stars 0 forks source link

Switched from Nette\Object to Nette\SmartObject - PHP 7.2 compatibility #136

Closed kratkyzobak closed 6 years ago

kratkyzobak commented 6 years ago

Due to PHP 7.2 compatibility of package switched from Nette\Object to Nette\SmartObject

Addresses https://github.com/drahak/Restful/issues/135

Note: package is still depndend on drahak\OAuth2, which uses Nette\Object, so using OAuth2 auth handler still does not work in PHP 7.2. All other features work.

kratkyzobak commented 6 years ago

There were failed checks due to old version of Nette for PHP 5.4 & PHP 5.5. If support is needed, I would recomend use another branch, or composer version.

hantc commented 6 years ago

@kratkyzobak hello, is there a way how to get this specific branch via composer? EDIT: got it: "drahak/restful": "dev-master#2bccb7207a195c3e5f1aa3f59d878177e37ef1d6",

jaroslavrehorka commented 6 years ago

What happened to the PHP7 branch? There is no such branch in this repo...

drahak commented 6 years ago

I renamed it to dev. There are some failing tests for older PHP versions I need to resolve before merging it into the main branch.

namo-R commented 6 years ago

Progress ? ;)

tprochazka commented 6 years ago

@drahak Weird. It was merged to PHP7 branch, and you told that it was renamed to dev. But when I check dev branch, it still use Nette/Object.

MartinMystikJonas commented 5 years ago

@drahak Any progress here? Can I do anything to help with PHP 7.2 compatibility? This issue blocked our upgrade to PHP7.2.