Closed crookse closed 12 months ago
Uffff... I can't believe I reviewed this. I tried to spot major stuff on this first pass. I'm going to be honest, I still have trouble linking what does what just from the code review screen. Will probably require more passes and clone the branch to understand better.
Overall, I see loads of potential, really good job!
The main problems I have is around enums and forcing logging. I think we should decorate (with the pattern, not the annotation) the methods if we want to add extra logging functionality.
With this review I we sparkle some discussion 😄 Again, awesome job!
thanks man! just remember, you laid the foundation for v3 so thank YOU for providing a branch to work off of 😄.
i agree with logging being introduced using the decorator pattern. the Mixin file that's currently unstable could do it pretty easily, so i'll get that working and provide the results of discussion.
thanks for reviewing man. v3 has been baking since like 2021 lol. it's finally coming together 🥹
Going to publish this to npm so I can consume the packages and see if the examples in the docs match up
Closes #668
Documentation is at: https://github.com/drashland/website-v2/pull/200 (revisions will be ongoing during beta)
TODO
CSRFNot supporting. Can be done in user land.GraphQLResourceLoaderNot supporting. Can be done in user land.Leftover TODOs
Note: The below TODOs will be done after beta release
dnt
to see ifURLPattern
gets polyfilled for runtimes that don't supportURLPattern