drdavella / ravendb

ACID Document Database
https://ravendb.net
Other
0 stars 0 forks source link

(sonar) Fixed finding: "Assertion arguments should be passed in the correct order" #4

Closed pixeebot[bot] closed 1 month ago

pixeebot[bot] commented 2 months ago

Remediation

This change fixes "Assertion arguments should be passed in the correct order" (id = csharpsquid:S3415) identified by sonar.

Details

A .NET assertion should have the hard-coded expected value as the first argument and the actual value should be the second argument. If these are reversed, the assertion error message will be misleading.

I have additional improvements ready for this repo! If you want to see them, leave the comment:

@pixeebot next

... and I will open a new PR right away!

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: sonar:dotnet/assert-order

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pixeebot[bot] commented 2 months ago

I'm confident in this change, but I'm not a maintainer of this project. Do you see any reason not to merge it?

If this change was not helpful, or you have suggestions for improvements, please let me know!

pixeebot[bot] commented 1 month ago

Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them!

pixeebot[bot] commented 1 month ago

This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know!

You can also customize me to make sure I'm working with you in the way you want.