dream-num / univer

Univer is an Isomorphic Full-Stack Framework for Creating and Editing Spreadsheets, Docs, and Slides Across Web and Server
https://univer.ai
Apache License 2.0
7.2k stars 639 forks source link

refactor: remove legacy menu service #4068

Closed jikkai closed 1 week ago

jikkai commented 1 week ago

close #xxx

Pull Request Checklist

github-actions[bot] commented 1 week ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
github-actions[bot] commented 1 week ago

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 8 seconds
commit  e5b7714
info  For more information, [see full report]()

Flaky tests chromium › memory/memory.spec.ts › memory
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.99%. Comparing base (3b8e690) to head (e5b7714). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/ui/src/common/menu-merge-configs.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4068 +/- ## ========================================== + Coverage 32.94% 32.99% +0.04% ========================================== Files 2497 2496 -1 Lines 126931 126759 -172 Branches 28422 28387 -35 ========================================== Hits 41821 41821 + Misses 85110 84938 -172 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.