dream-num / univer

Univer is an Isomorphic Full-Stack Framework for Creating and Editing Spreadsheets, Docs, and Slides Across Web and Server
https://univer.ai
Apache License 2.0
7.2k stars 639 forks source link

fix(formula): update formula string in other sheet #4107

Closed Dushusir closed 1 day ago

Dushusir commented 3 days ago

What's updated?

  1. Write a formula =SUM(Sheet1!A1:A3) in Sheet2
  2. Delete the second row in Sheet1
  3. Expected: The formula in Sheet2 is updated to =SUM(Sheet1!A1:A2)

Pull Request Checklist

github-actions[bot] commented 3 days ago

View Deployment

πŸ“‘ Examples πŸ“š Storybook
πŸ”— Preview link πŸ”— Preview link
github-actions[bot] commented 3 days ago

Playwright test results

passed Β 20 passed

Details

stats Β 20 tests across 9 suites
duration Β 4 minutes, 48 seconds
commit Β 2fc5aee
info Β For more information, [see full report]()

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (545dc82) to head (2fc5aee). Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...formula/src/controllers/utils/ref-range-formula.ts 0.00% 47 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4107 +/- ## ========================================== + Coverage 33.32% 33.78% +0.46% ========================================== Files 2440 2457 +17 Lines 126792 127631 +839 Branches 28364 28571 +207 ========================================== + Hits 42250 43126 +876 + Misses 84542 84505 -37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: