dreamland-mud / mudjs

WebSocket MUD client for DreamLand
https://dreamland.rocks/mudjs/
GNU General Public License v3.0
16 stars 9 forks source link

Makes it impossible to bind these keys as hotkeys via the web client #50

Closed tasatko closed 3 years ago

tasatko commented 3 years ago

https://github.com/dreamland-mud/mudjs/blob/ea5b9bf0286d3ac35f72a0ae3e01b94d88f6874b/src/components/cmdinput.js#L64

ruffinakoza commented 3 years ago

@tasatko do you remember if it was possible before this latest refactoring? Basically I just need to know if it's a valid use case and is used by someone, and if yes, we can think of a fix.

tasatko commented 3 years ago

I don't remember but I think before last refactoring was the same issue (this part was just relocated from file /src/input.js).

Problem is not every keyboard has keypad, so those keys likely be bind for moving.

ruffinakoza commented 3 years ago

Ok, makes sense. I'll look at a fix once back working on that piece of code.

ruffinakoza commented 3 years ago

Fixed in feature/commands, can now do #set isPgKeysScroll false to disable default scrolling behavior.