[#37] Allowed config filename

tannguyen04 commented 8 months ago

Checklist before requesting a review

closes #37

[x] I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
[x] I have added a link to the issue tracker
[x] I have provided information in Changed section about WHY something was done if this was not a normal implementation
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run new and existing relevant tests locally with my changes, and they passed
[x] I have provided screenshots, where applicable

1.

tannguyen04 commented 8 months ago

Hi @AlexSkrypnyk I have few notes

With url token replacements, I am using url encode to build the token replacement. I can not find the way to follow your logic with url tokens.
Step name token should not lower cased because some case is sensitive. Ex: https://github.com/drevops/behat-screenshot/pull/94/files#diff-88ecc745a3641e37dcc57852c6bde91b4a709b0d10026876da436f918feb687dR68

tannguyen04 commented 8 months ago

@tannguyen04 Could you please:

Extract all token-related functionality in to Tokenizer class.

Add unit tests for Tokeniser class.

Hi @AlexSkrypnyk

I have done 1 & 2. But phpunit does not pick my test. And it reach over 16hours. Can you please look into that ? Thanks.

xurizaemon commented 8 months ago

Great work @tannguyen04! 🎈