new comment thread designs

[drewrehfeld]

update designs with what i sent you

[drewrehfeld]

This is the #1 highest priority of anything @asimshahzadmjc

[asimshahzadmjc]

@drewrehfeld You did not added appropriate label so that is why it remains

[asimshahzadmjc]

@drewrehfeld This one is completed and uploaded. Currently there is one small issue not related to this one i-e the issue is currently the reply to main news feed item is currently possible where as replying to a reply currently adds comment against the main news feed item. I think there should be only three levels of reply to make the design look appealing. 1) News feed it self 2) Reply to Main News Feed 3) Reply to Child News Feed

I hope you understood what I meant here :)

As far as design is concerned that is uploaded so please do have a look at that as soon you have time :)

[drewrehfeld]

@asimshahzadmjc yes, i believe this is how i designed it

[drewrehfeld]

@asimshahzadmjc some issues:

1. the comment box gets too tall on small screens

should be like design:

2. make paperclip attach button default style (white, not blue)

3. there needs to be more margin between the line | for the comment and the bottom of the button group (like, dislike, comment, edit, etc.). currently margin top is -25px, but it should be -10px. id=news_feed_comment554

4. replying to post, all replies should appear (no show/hide replies) and new comment should be below the rest

[drewrehfeld]

@asimshahzadmjc

• [x] it looks like an <hr /> has been added between comments. this should not be here. these are appearing all over the plce

• [x] 1. not fixed

• [x] 2. not fixed

• [x] 3. not fixed

• [x] 4. i still want show/hide replies. i am saying that when a user clicks to reply, the comments will not be hidden anymore and the reply will appear at the bottom. i see that the reply appears at the bottom, but the comments should still be hidden until user clicks reply button. then, they are expanded and reply is at the bottom. in future i wanted to show only the most recent reply when comments are hidden and the show comments link is above. then, when user clicks show all or reply, it will show all the comments.

[drewrehfeld]

@asimshahzadmjc do you have time for a call about this tomorrow? the comment function is all over the place. it should work basically like facebook, so there hsould be no confusion here.

[drewrehfeld]

@asimshahzadmjc i like the action now :) i will do some more testing

[drewrehfeld]

@asimshahzadmjc replies do not seem to be working. i cannot post a comment reply.

• [x] #5 above, i moved here and added more detail:

5. I tried to reply to a student and it didn't work @asimshahzadmjc

5.1. it should say @emiliano garcia, since i am replying to him

5.2. my reply should be indented

5.3. it didn't work

There are three levels of posts:

a. initial post from the top of the newsfeed b. reply to initial post (1 indent) c. reply to reply (2 indents) d. reply to reply to reply, etc. (2 indents)

C, reply to reply should be indented directly below the reply. it should not be at the bottom of the entire initial post.

D, reply to reply to reply, etc., will have same indent as D and comment will go at the bottom of reply to reply, not the bottom of the entire initial post.

[asimshahzadmjc]

@drewrehfeld I am finalizing this my self :) The new developer was kind of struggling with this one so have moved him on message design to expedite the development effort User should be able to reply to a reply which is effectively third level I am working on that as of now. Will let you know once that is completed as well so that you can finalize your testing of this new feature.

[drewrehfeld]

@asimshahzadmjc ok great :)

[drewrehfeld]

• [ ] #6 the comment field should automatically get taller if the input is longer than the field. it should act like this input field on github—though it will start with just one line.

[asimshahzadmjc]

@drewrehfeld The reply to a reply will be indented right below the reply which is been replied right? Just want to make sure

[drewrehfeld]

@asimshahzadmjc yes, i think we are on the same page here :)

[asimshahzadmjc]

[asimshahzadmjc]

@drewrehfeld overall comments are working properly now. Its just mobile design and your last comment which remain. Please test that I will fix these in morning.

[asimshahzadmjc]

6 the comment field should automatically get taller if the input is longer than the field. it should act like this input field on github—though it will start with just one line.

Everything for comments on news feed is completed now.

As far the above shared item is concerned that will create issues with design because our buttons height will be less if we increase the height based upon increased text. So I think we can look into that some other time. What you say? @drewrehfeld

[drewrehfeld]

@asimshahzadmjc i still want it to add more lines below, regardless

[asimshahzadmjc]

@drewrehfeld Ready for testing

[drewrehfeld]

@asimshahzadmjc the way you have aligned the right border of the text box with the left side of the paperclip button is good. this is how the messages design should look. However, when more lines are added, make sure the top of the text box is still aligned with the top of the paper clip button and reply button.

[asimshahzadmjc]

@drewrehfeld Ready for testing

[drewrehfeld]

@asimshahzadmjc looks good! there is just one error. for some reason it sometimes says that i am replying to the initial post and not the child.

[asimshahzadmjc]

@drewrehfeld I did tried to reproduce but was not able to do that. Will give this one another try and fix if I see any issue