search

drfraker / snipe-migrations

Blazing fast database migrations for Laravel tests.
MIT License
290 stars 32 forks source link

Add postgres support #4

Open matijakovacevic opened 5 years ago

matijakovacevic commented 5 years ago

is it planned?

drfraker commented 5 years ago

No, I haven't planned it, yet... Do you want to submit a PR to add support for it? I want to add support for sqlite and in-memory sqlite. To do this I'm thinking about splitting out some code and using database drivers to handle the snapshot creation and import stuff. Once that's done adding postgress should be much easier.

matijakovacevic commented 5 years ago

To do this I'm thinking about splitting out some code and using database drivers to handle the snapshot creation and import stuff

Good point and I totally agree. I could make a PR for Postgres. Tag me in this issue once you've completed code rewrite using db drivers. Until then I will try to go through the code to see the details of the package.

P.S. As the package is specific to Laravel and still fresh, a proposition about package naming convention.

Something along the line drfraker/laravel-nameofpackage, to imply an extension upon the framework and not a general package.

drfraker commented 5 years ago

Does the latest pull request help solve this issue? PR 29