search

drhenner / ror_ecommerce

Ruby on Rails Ecommerce platform, perfect for your small business solution.
www.ror-e.com
MIT License
1.21k stars 409 forks source link

simple-form-bootstrap branch status? #70

Closed knf closed 11 years ago

knf commented 12 years ago

I was wondering how far the simple-form-bootstrap branch was taken. I would like to use ror-ecommerce but would prefer to use boostrap. I am curious how complete the simple-form-bootstrap branch is? I might be willing to try to bring that branch up to date as much as possible with master but implement all the frontend code with simpel_form and boostrap.

Thoughts?

drhenner commented 12 years ago

I didn't write the code in that branch but I sorta rejected the idea of merging that branch also.

My reasoning was it adds one more layer of complexity. I know simple-form and bootstrap are great but one thing i dont want to do is add 20 simple things thus creating a larger learning curve.

That said I think it' "young" enough that you could merge with master easy enough.

knf commented 12 years ago

I agree with you. I was just wondering how for along they got with that branch in terms of switching over all the views and styles etc or if it was half implemented etc.

I will check out the code and trying merging etc

mitfik commented 12 years ago

The code should be written in a way that will not depend on any of this framework. There was good point here: https://github.com/drhenner/ror_ecommerce/issues/62#issuecomment-8952016

And I think in near future we will have it ;)

drhenner commented 11 years ago

I'm going to close this.. It isn't a bug (more of a wish list) I'll add to the wish-list wiki.