Remove misleading statement from README.md

[davidcelis]

Remove statement that Engines and frameworks are nonstandard ways of using Ruby on Rails. Engines are Rails applications themselves, and using frameworks/gems is hardly nonstandard; most Ruby and Rails applications do.

Signed-off-by: David Celis david@davidcelis.com

[Spaceghost]

:+1: Can we get this merged quickly?

[whitmanc]

+1

[sevenseacat]

+1

[drhenner]

I updated the Readme but will reject the pull request. Is there a spree meetup tonight?

[Spaceghost]

I am disappoint.

[drhenner]

SPace Ghost. Why is that? I made the change asked, I just didn't remove that this is an e-commerce platform. Unless that was what he wanted to remove... hmmmm =)

[Spaceghost]

DAvid Henner, oh don't worry about it.

[radar]

As one of the Spree developers and as someone who devoted a whole chapter of his book to engines and as someone who wrote the engines guide and as someone who prolifically endorses the "Rails Way" in regards to engines, I'd like to know how we, in Spree, are not correctly using Rails engines.

If you could explain that in more elaborate terms, perhaps we could come to some sort of agreement. Coming out and saying right off the bat that we're not using Rails in a standard way is kind of bullshit, imo. Facts plzkthx.

[radar]

Also, in regard to your comment:

Also rails 2 engines were pretty much hated and never used by the community. I'd say they changed so much that they have only been around since rails 3.

This was true because the engines stuff were maintained as a separate plugin, up until 2.3 was released with half-baked engine support (kind of like how the asset pipeline was half-baked into 3.1). I agree that engine support did suck for earlier releases. Engine support now is incredibly better and you can do a ton of great things with engines.

Please remove the comment from your README, as I feel it is unnecessary and slanderous.

[drhenner]

Ryan,

First please please please, I am not here to pick a fight.

Do you remember Spree 2 years ago? It had it's own way of doing things. I actually love the work you have done. Spree is a better project with you.

Spree had a very complex engine-like system 2 years ago. Can we agree to that?

My wording should have been:

Yet it definitely did not use Rails in a standard way.

vs

Yet it definitely does not use Rails in a standard way.

SORRY my bad.

I have no idea how spree is doing things now. That isn't 100% true (I have had a few rescue projects I needed to work on) but I don't follow all the work in spree regularly. I tried helping out last year but whether it was intended or not I was shot down....

Heck look at my tweet just a couple days ago. Someone was endorsing the blog post I had knocking spree. I replied saying it wasn't up to date and basically should be taken with a grain of salt.

https://twitter.com/search/realtime?q=ror_ecommerce&src=savs

I Also started a ruby e-commerce group in SF and have reached out to sean to get someone to endorse spree. I know one of the members also reached out to you. I really do want spree to succeed.

Lastly. I removed the comment well before you entered this discussion. but no I will not accept the pull request because it removed This is a Rails e-commerce platform.

[drhenner]

BTW: I love Rails 3 engines. KUDOS for all the work on that.

[davidcelis]

I did not remove a comment that ror_ecommerce is an e-commerce platform, because the very next paragraph mentions so: ROR Ecommerce is a *Rails 3 application* with the intent to allow developers to create an ecommerce solution easily.

If anything, I removed a redundancy.

[drhenner]

Are we debating the redundancy now?

[radar]

First please please please, I am not here to pick a fight.

Understood.

Do you remember Spree 2 years ago? It had it's own way of doing things.

Everything had it's own way of doing things. Engines weren't a standard thing back then. Redmine, for instance, still has a stupidly complex plugin architecture. Projects like Refinery have gone done the right path too.

I actually love the work you have done. Spree is a better project with you.

Thanks for that.

Spree had a very complex engine-like system 2 years ago. Can we agree to that?

Yes we can agree on that.

I have no idea how spree is doing things now. That isn't 100% true (I have had a few rescue projects I needed to work on) but I don't follow all the work in spree regularly. I tried helping out last year but whether it was intended or not I was shot down....

It was not intentionally shot down. Sorry if you feel that way. Your patches are more than welcome to Spree. The only issue I can find from you is on the old lighthouse tracker, and is from 2010. Was that the issue?

Heck look at my tweet just a couple days ago. Someone was endorsing the blog post I had knocking spree. I replied saying it wasn't up to date and basically should be taken with a grain of salt.

The blog post is inflammatory, "chest-beating", and extremely biased. Nobody should be using that to pick a favourite between one or the other. It's probably best that it is taken down.

I Also started a ruby e-commerce group in SF and have reached out to Sean to get someone to endorse Spree. I know one of the members also reached out to you. I really do want spree to succeed.

The member did indeed reach out and we tried to help them get some merchandise for the meetup but for whatever reason, the person at Spree who manages the merch didn't see/reply to the emails. Thank you for organising the meetup.

Lastly. I removed the comment well before you entered this discussion. but no I will not accept the pull request because it removed This is a Rails e-commerce platform.

FWIW, I think the first sentence is indeed redundant. The text would read a lot better without it.

[drhenner]

Just a final word (I'm hoping a final word at least. =) ).

RE: The blog post is inflammatory, "chest-beating", and extremely biased. Nobody should be using that to pick a favourite between one or the other. It's probably best that it is taken down.

Yes it was. I was super upset working on an old version of spree daily. Did you see my reply to the tweet? I told the guy it was an out of date blog post. Basically telling him to read it with a grain of salt.

I favorited and unfavorited the post. I pretty much favorite and post that links to ror-e (I assume you can understand) Then after I gave it some thought I unfavorited the post.

All said, I don't delete my blog posts. I'll own up to what I wrote at the time. At the time a believed what I said. That might be a bit "arrogant" but hey... I am a bit arrogant. (BTW: I wrote that after reading "rework" DHH said don't be afraid to "pick a fight" in the book.)

---

RE: It was not intentionally shot down. Sorry if you feel that way. Your patches are more than welcome to Spree. The only issue I can find from you is on the old lighthouse tracker, and is from 2010. Was that the issue?

I directly contacted the guys during the first spree-conf. I was in NYC 2 blocks away. They were too busy during the conf which was understood. Trying to set up a skype meeting was canceled and after a couple weeks I dropped it. Really no big deal but I did have a few ideas I wanted to help spree with. I'd have to put a few hours of work in to remember the feedback I wanted to give and to see if spree hasn't already resolved the issues.

---

Either way, The comment that was deleted, was something I wrote 2 years ago. I had not even looked at it for 2 years. Once they did the pull request (I'm assuming with you in the same room???) I made the change in less than 15 minutes from receiving the request. I agree the comment was BS especially since engines are now VERY COOL!!!