search

drmacro / wordinator

Generate high-quality DOCX files using a simplified XML format (simple word processing XML).
Apache License 2.0
37 stars 8 forks source link

Fix for issue #109 #113

Closed larsga closed 1 month ago

larsga commented 1 year ago

We ensure that empty table cells in the input have at least an empty paragraph in the output.

Note that this PR builds on the "refactor tests" PR, so that needs to be merged first.

larsga commented 1 year ago

And I see my commits are now suddenly unverified again. I don't know why, but will fix that.

drmacro commented 1 year ago

I'm going to close this PR because the branch is out of date and we can get the useful stuff from this branch manually or via cherry pick if needed.

We can resolve on the most appropriate code fix once the other PRs have been integrated--ultimately it's a small change to the table handling.

larsga commented 1 year ago

This branch still has commits that we need to get onto develop, so reopening it.

larsga commented 2 months ago

The fix for issue #134 was basically a fix for the same issue as this PR, but that fix was too simple. It's necessary for table cells to end with a paragraph if Word is to be happy. This PR has two automated tests that verify this, and the code currently in the repo fails those two tests.

I've now merged in all the code from the repo, and then reapplied these fixes on top.

It would be great if we could get this PR merged, because this is a fix we really need in our software. We have been using our own build of Wordinator (which has this fix), but we would very much like to switch to the standard Wordinator. That requires this issue to be fixed, though.

ekimbernow commented 1 month ago

Closing as complete.

I manually copied the code from this PR into the code on the develop branch. New test cases and update empty table cell cases pass, generated Word docs open without error.

larsga commented 1 month ago

Thanks for incorporating the fix. I don't really care how it's done, as long as the problems get fixed.