dronecan / pydronecan

python DroneCAN code generation, interface and utilities
MIT License
40 stars 43 forks source link

Add additional dsdl path for loading #21

Closed marcojob closed 2 years ago

marcojob commented 2 years ago

Add additional DSDL path for loading correctly in PX4-Autopilot, this should fix the issue dronecan/libuavcan#3

potaito commented 2 years ago

I too ran into the issue you mentioned when trying to compile PX4. I can confirm that this fix works for PX4 with the following settings:

Since you are just adding yet another search path to the list, I don't see any harm in merging this. And thanks for saving me some time :)

EDIT: for PX4 users, here's the quick fix

# Check out libuavcan latest main
cd /<yourpath>/PX4-Autopilot/src/drivers/uavcan/libuavcan
git fetch origin
git checkout 5eec0220

# Apply this PR for pydronecan
cd /<yourpath>/PX4-Autopilot/src/drivers/uavcan/libuavcan/libuavcan/dsdl_compiler/pyuavcan
git remote add marcojob git@github.com:marcojob/pydronecan.git
git fetch marcojob
git checkout pr-fix-dsdl-load
potaito commented 2 years ago

@tridge merge? :smile:

aentinger commented 2 years ago

This resolves the issue described here also for me. Please merge and update libuavcan :+1:

potaito commented 2 years ago

Thank you kind sir!!!