synrg
commented
4 years ago In this series of commits, the cache of users is now enhanced to ensure a lookup by login id will retrieve any user primed into the cache either by the initial load of all users for the user projects, or by lookup via ,user discord_id: bdbaab2a4567f504819f4885643a59e97b94dd7b a82c821bf5d06bb6109d24fc2ef4f8b045ed2d25 eeadadd8aa1da9c18026596d42a6ebe8dc41f894 (initial commit, & two additional commits fixing regressions discovered after Dronefly had been updated already - oops).
Previously a lookup by login id would have needlessly done a redundant lookup of the user via the API.
To test this feature, as well as providing a way to place unregistered users into the cache, ,iuser <login> was added to lookup iNat users by login regardless of whether they are registered to the bot or not.
Having laid this groundwork, next:
- ContextMemberConverter can now consider exact matches against cached login ids without the cost of lookup through the API as a match.
- As well, a reverse mapping of iNat ids known in the guild back to guild member user ids would need to be written to complete the feature.
As per description: anywhere that
useris accepted as input, an iNat user id registered to the bot should work as well, except in cases whereuserindicates an unregistered user (e.g.,user add). This includes adding users by name to the observation/species/leaf taxa counts tables on taxon & obs embeds.Do this instead of #90 , since there often isn't room in the Discord nickname to also & it's unlikely many would want to do that anyway.