dropbox / dropbox-sdk-js

The Official Dropbox API V2 SDK for Javascript
https://www.dropbox.com/developers
MIT License
942 stars 354 forks source link

Change deprecated .buffer() to .arrayBuffer() #1137

Open MariusVB opened 7 months ago

MariusVB commented 7 months ago

https://github.com/dropbox/dropbox-sdk-js/blob/6bfaf895b757d7bd1e65002847a7c801813cc210/src/response.js#L51

The .buffer() will be removed in upcoming node versions. On node 20, I'm getting a deprecation error at every file download...

greg-db commented 7 months ago

Thanks for the report! I'll ask the team to update that.

MariusVB commented 7 months ago

Are you a bot @greg-db ?

greg-db commented 7 months ago

@MariusVB No, I am not a bot. I am a real person monitoring these issues.

toddjudd commented 2 months ago

@greg-db I created and closed an issue to make the same fix. any chance this gets merged? I'm monkey patching for the time being.

greg-db commented 2 months ago

@toddjudd Thanks for the note. This is still open with the team but I don't have an update on it yet. I'll follow up here once I do.