dropbox / dropbox-sdk-js

The Official Dropbox API V2 SDK for Javascript
https://www.dropbox.com/developers
MIT License
942 stars 354 forks source link

node-fetch Deprecation of response.buffer #1144

Closed toddjudd closed 2 months ago

toddjudd commented 2 months ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch dropbox@10.34.0 for the project I'm working on.

I ran into an issue where using the built in fetch with node v20 didn't work so uppon switching to node-fetch I ran into a deprication warning

(node:40056) [node-fetch#buffer] DeprecationWarning: Please use 'response.arrayBuffer()' instead of 'response.buffer()'
(Use `node --trace-deprecation ...` to show where the warning was created)

Here is the diff that solved my problem:

diff --git a/node_modules/dropbox/cjs/src/response.js b/node_modules/dropbox/cjs/src/response.js
index ec37d1b..fe42b32 100644
--- a/node_modules/dropbox/cjs/src/response.js
+++ b/node_modules/dropbox/cjs/src/response.js
@@ -64,7 +64,7 @@ function parseDownloadResponse(res) {
         return resolve(data);
       });
     } else {
-      res.buffer().then(function (data) {
+      res.arrayBuffer().then(function (data) {
         return resolve(data);
       });
     }

This issue body was partially generated by patch-package.

toddjudd commented 2 months ago

Closed as it duplicates #1137