Closed LotharukpongJS closed 1 year ago
If I may add another point, I think the README.md
should say libomp
rather than lomp
.
to
brew install llvm libomp
cd /usr/local/lib
ln -s /usr/local/opt/libomp/lib/libomp.dylib ./libomp.dylib
This may have come from https://github.com/drostlab/myTAI/pull/26. It seems like lomp
doesn't exist and is a spelling mistake.
$ brew install lomp
==> Downloading https://formulae.brew.sh/api/formula.jws.json
==> Downloading https://formulae.brew.sh/api/cask.jws.json
Warning: No available formula with the name "lomp". Did you mean libomp?
==> Searching for similarly named formulae and casks...
==> Formulae
libomp ✔
To install libomp ✔, run:
brew install libomp ✔
==> Casks
loom
To install loom, run:
brew install --cask loom
Excellent points! I fully agree and merged now.
Many thanks, Hajk
Dear Hajk,
I think PlotSignatureTransformed() should run with the default installation of
myTAI
withoutDESeq2
.However,
PlotSignatureTransformed()
hadvst
as one of the transformations as a default, i.e.transforms = c("none", "log2", "sqrt", "vst", "rank", "squared")
. Since,vst
is from the DESeq2 package and in case DESeq2 is not installed or doesn't satisfyDESeq2 (>= 1.29.15)
, then the function will not work.The default parameters are now.
However, the issue of
ks.test.default
warning messages forTestStatistic = "FlatLineTest"
remains.Best, Sodai